Skip to content

Adding tests for AI pytorch container#752

Closed
chajain wants to merge 1 commit intoSUSE:mainfrom
chajain:bci_pytorch
Closed

Adding tests for AI pytorch container#752
chajain wants to merge 1 commit intoSUSE:mainfrom
chajain:bci_pytorch

Conversation

@chajain
Copy link
Copy Markdown

@chajain chajain commented Feb 18, 2025

No description provided.

Copy link
Copy Markdown
Contributor

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit bare bones but should work

@chajain chajain force-pushed the bci_pytorch branch 2 times, most recently from c2b9607 to 81f30d2 Compare February 19, 2025 22:45
Copy link
Copy Markdown
Contributor

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails when executed as the pytorch container is not available via registry.suse.de/suse/sle-15-sp6/update/products/ai/totest/images/containers/pytorch:2.5

I could only find it in devel/ai/containers/containers/pytorch. Can you please link it into the correct place?

@guangyee
Copy link
Copy Markdown

guangyee commented Mar 4, 2025

@chajain looks like we should be using the 2.5.0 tag instead of 2.5. See registry.suse.de/suse/sle-15-sp6/update/products/ai/totest/images/containers/pytorch:2.5.0

@chajain chajain force-pushed the bci_pytorch branch 2 times, most recently from 25fb5b5 to 596ce83 Compare March 4, 2025 22:21
)

PYTORCH_CONTAINER = create_BCI(
build_tag=f"{SAC_CONTAINER_PREFIX}/pytorch:2.5.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to bump this string on every version bump in pytorch, which seems extremely wasteful to me. Can you use a more generic tag? Or are you really expecting to stay at 2.5.0 for an extended period of time?

@dcermak
Copy link
Copy Markdown
Contributor

dcermak commented Mar 20, 2025

Closing in favor of #768

@dcermak dcermak closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants